[Crawl] Stash tracking bug?

G

Guest

Guest
Archived from groups: rec.games.roguelike.misc (More info?)

While browsing through my *.lst file, I suddenly saw a yet unknown hat
in one of my stashes, a really good one btw (+2, with teleport),
something I surely would use now instead of my current +2 visored
helmet. So I rushed down to the Lair 8 and to my greatest disappointment
it was just the well known '+2 wizard's hat of Weirdness', nothing
special. The other 3 items where the same as shown in my *.lst file, so
I'm sure it was exactly this pile. After dropping the hat again, the lst
file now shows the correct content again.

I'm somewhat reluctant to mention that I also lost the information about
my stash of honeycombs and royal jellies. Reluctant cause though I'm
*sure* it exists, I'm not sure whether I left that stash in an secure
area or not. I'm pretty sure it was near the entrance of the Hive, I'm
going to have a look now...

As a less important sidenote (I guess this part wasn't touched), this is
still the "old" patch, w/o the multidrop enhancement...

Rubinstein
 
Archived from groups: rec.games.roguelike.misc (More info?)

Rubinstein <picommander@t-online.de> wrote:

> While browsing through my *.lst file, I suddenly saw a yet unknown
> hat in one of my stashes, a really good one btw (+2, with
> teleport), something I surely would use now instead of my current
> +2 visored helmet. So I rushed down to the Lair 8 and to my
> greatest disappointment it was just the well known '+2 wizard's hat
> of Weirdness', nothing special.

This is the maddening randart-reshuffle bug. Tina Hall first reported
this, ages ago, but it's proved difficult to track down (part of the
reason it's been difficult to track down is that I haven't given it
much attention). I'll look into it again.

> I'm somewhat reluctant to mention that I also lost the information
> about my stash of honeycombs and royal jellies. Reluctant cause
> though I'm *sure* it exists, I'm not sure whether I left that stash
> in an secure area or not. I'm pretty sure it was near the entrance
> of the Hive, I'm going to have a look now...

I'm anxious to see the result. 🙂

> As a less important sidenote (I guess this part wasn't touched),
> this is still the "old" patch, w/o the multidrop enhancement...

Well, I've neglected the stash-tracker for quite a while, so any bugs
in it are likely to have a long, dishonourable, history.

Darshan
 
Archived from groups: rec.games.roguelike.misc (More info?)

Darshan Shaligram <scintilla@gmail.com> wrote:
> Rubinstein <picommander@t-online.de> wrote:

>> While browsing through my *.lst file, I suddenly saw a yet
>> unknown hat in one of my stashes, a really good one btw (+2, with
>> teleport), something I surely would use now instead of my current
>> +2 visored helmet. So I rushed down to the Lair 8 and to my
>> greatest disappointment it was just the well known '+2 wizard's
>> hat of Weirdness', nothing special.

> This is the maddening randart-reshuffle bug.
[...]
> I'll look into it again.

Well, that was a pretty stupid bug. It's not the first time I've
been bitten by sign-extension when casting a signed short to long.
Fixed now, thanks!

The fixed patch and Windows binary are up at the usual places:

http://www.angelfire.com/trek/mazewest/crawl/crawl-patches.diff.gz

and

http://www.angelfire.com/trek/mazewest/binaries/dc400b26tr-w32.zip

For your current game, you can make this change to your source and
recompile (or leave the code as it is - the bug should be harmless):

Replace the readLong() function at the end of files.cc with this
one:

long readLong(FILE *file) {
return ((long) (unsigned short) readShort(file)) << 16 |
(long) (unsigned short) readShort(file);
}

Darshan
 
Archived from groups: rec.games.roguelike.misc (More info?)

Darshan Shaligram wrote:
> Rubinstein <picommander@t-online.de> wrote:
>
>> While browsing through my *.lst file, I suddenly saw a yet unknown
>> hat in one of my stashes...
>> [...]
>> I'm somewhat reluctant to mention that I also lost the information
>> about my stash of honeycombs and royal jellies.
>> [...]
>
> I'm anxious to see the result. 🙂

All clear, everything is in place. 🙂
Is it possible/thinkable that it also was an outcome of the
above-mentioned or another bug probably? Though I can't swear that I
just didn't forgot to mark that pile with ctrl-S, I consider this as an
unlikely case. This pile was (is) one of my more important ones.

Rubinstein
 
Archived from groups: rec.games.roguelike.misc (More info?)

Darshan Shaligram wrote:
> Darshan Shaligram <scintilla@gmail.com> wrote:
>> Rubinstein <picommander@t-online.de> wrote:
>
>>> While browsing through my *.lst file, I suddenly saw a yet unknown
>>> hat in one of my stashes...
>>> [...]
>
>> This is the maddening randart-reshuffle bug.
> [...]
>> I'll look into it again.
>
> Well, that was a pretty stupid bug. It's not the first time I've
> been bitten by sign-extension when casting a signed short to long.
> Fixed now, thanks!
> [...]
> For your current game, you can make this change to your source and
> recompile (or leave the code as it is - the bug should be harmless):

My current char seems tougher than expected and, due to this really good
news, I just decided to change my mind, making a backup of my char and
trying the new patch...

Rubinstein
 
Archived from groups: rec.games.roguelike.misc (More info?)

Darshan Shaligram wrote:
> Darshan Shaligram <scintilla@gmail.com> wrote:
>> Rubinstein <picommander@t-online.de> wrote:
>
>>> While browsing through my *.lst file, I suddenly saw a yet unknown
>>> hat in one of my stashes, a really good one btw (+2, with teleport),
>>> something I surely would use now instead of my current +2 visored
>>> helmet. So I rushed down to the Lair 8 and to my greatest
>>> disappointment it was just the well known '+2 wizard's hat of
>>> Weirdness', nothing special.
>
>> This is the maddening randart-reshuffle bug.
> [...]
>> I'll look into it again.
>
> Well, that was a pretty stupid bug. It's not the first time I've
> been bitten by sign-extension when casting a signed short to long.
> Fixed now, thanks!

At first the good news: I just compiled the patch, and - the first
multidrop test was successful!
<<<*XXL-grin*>>> (dunno how to express my joy)

But now the bad news. The bug above isn't solved. Here it is again:

(0, 0)
the +2 wizard's hat of Eternal Vigilance
It affects your accuracy (+4).
It makes you much more stealthy.
It lets you teleport.

Exactly the same hat as before, when I met the bug for the first time.
I wished it would be mine, but meanwhile I know it's not real... :-(

I've also found another curiosity, something entirely else, though.
When I compared my old crawl binary with the new one, I suddenly found
the new one significantly smaller. To be honest, I never took care of
the size of that binary, since it just worked. It's size is - fasten
your seat belts, please - ~17Mb! The new one is *only* ~7Mb in size, big
enough, but looks a lot more reasonable to me. Could anyone please tell
me how it's possible that 2 binaries of the same source differ so much
in size *and* are both working properly? I hardly can believe that the
patch could have something to do with it...

Rubinstein
 
Archived from groups: rec.games.roguelike.misc (More info?)

Rubinstein <picommander@t-online.de> wrote:
[...]
> At first the good news: I just compiled the patch, and - the first
> multidrop test was successful!
> <<<*XXL-grin*>>> (dunno how to express my joy)

Great! 🙂

> But now the bad news. The bug above isn't solved. Here it is
> again:

> (0, 0)
> the +2 wizard's hat of Eternal Vigilance
> It affects your accuracy (+4).
> It makes you much more stealthy.
> It lets you teleport.

> Exactly the same hat as before, when I met the bug for the first
> time. I wished it would be mine, but meanwhile I know it's not
> real... :-(

Could you revisit the square the hat is on, get out of LOS of that
square, save, reload, then dump and check the lst file? The hat
should be back to normal, and should stay normal thereafter. If not,
the bug is indeed alive and kicking.

What I see happening is this: when certain randarts are loaded from
the .st file, their properties get scrambled. Thereafter, the
properties stay scrambled until you actually go step on the square
in question (whereupon the stash-tracker throws away the items it
remembered and regenerates the list). The fix prevents the
scramble-on-load, but it doesn't affect already-scrambled items.

> I've also found another curiosity, something entirely else,
> though. When I compared my old crawl binary with the new one, I
> suddenly found the new one significantly smaller. To be honest, I
> never took care of the size of that binary, since it just worked.
> It's size is - fasten your seat belts, please - ~17Mb! The new one
> is *only* ~7Mb in size, big enough,

Whoa, both look huge to me. I don't know what the deal there is,
though.

Darshan
 
Archived from groups: rec.games.roguelike.misc (More info?)

Darshan Shaligram wrote:
> Rubinstein <picommander@t-online.de> wrote:
> [...]
>
>> But now the bad news. The bug above isn't solved.
>> [...]
>
> Could you revisit the square the hat is on, get out of LOS of that
> square, save, reload, then dump and check the lst file? The hat should
> be back to normal, and should stay normal thereafter. If not, the bug
> is indeed alive and kicking.

I did it (for a small fee of 3 honeycombs you please send to the address
below ***). All clear, the *.lst file correctly shows the wizard's hat
of Weirdness now. 🙂

Rubinstein
*** TicMuna@/opt/crawl/lib/TicMuna1000.zip
 
Archived from groups: rec.games.roguelike.misc (More info?)

Rubinstein <picommander@t-online.de> wrote:
> Darshan Shaligram wrote:
>> Rubinstein <picommander@t-online.de> wrote:
>> [...]
>>> But now the bad news. The bug above isn't solved.
>>> [...]
>> Could you revisit the square the hat is on, get out of LOS of
>> that square, save, reload, [etc.]

> I did it (for a small fee of 3 honeycombs you please send to the
> address below ***).

I'm clean out of honeycombs, but I can do beef jerky. Interested?

> All clear, the *.lst file correctly shows the wizard's hat of
> Weirdness now. 🙂

Neat!

Darshan
 
Archived from groups: rec.games.roguelike.misc (More info?)

Darshan Shaligram wrote:
> Rubinstein <picommander@t-online.de> wrote:
>> Darshan Shaligram wrote:
>>> Rubinstein <picommander@t-online.de> wrote:
>>> [...]
>> I did it (for a small fee of 3 honeycombs you please send to the
>> address below ***).
>
> I'm clean out of honeycombs, but I can do beef jerky. Interested?

No thanks. Now, where the usefulness of my amulet of controlled flight
has been somewhat relativated, I'm constantly wearing the amulet of the
gourmand again. And, as a result, I'm eating almost everything, most of
the time I'm full. This DE is going to be the fattest Elf you ever seen
before. If I continue this way, I'll soon get stuck in small one-square
corridors...

Rubinstein
 
Archived from groups: rec.games.roguelike.misc (More info?)

Rubinstein wrote:

> [...] Now, where the usefulness of my amulet of controlled flight
> has been somewhat relativated, I'm constantly wearing the amulet of the
> gourmand again.

= i foo p
= i foo r

R p P r
P p R r

Never go hungry again, no matter what else might be wanting that slot! ;-)

Erik
 
Archived from groups: rec.games.roguelike.misc (More info?)

"Erik Piper" <efrniokr@sdky.cz> writes:

>P p R r

ITYM 'R r P p'. HTH HAND.

-Jukka
--
Jukka Kuusisto
 
Archived from groups: rec.games.roguelike.misc (More info?)

bork bork bork Jukka Kuusisto bork 12:11:32 AM bork 12/22/2004 bork bork:

> "Erik Piper" <efrniokr@sdky.cz> writes:
>
> > P p R r
>
> ITYM 'R r P p'. HTH HAND.
>
> -Jukka

I do. Thanks!

E.