So i've been trying to forward a port on my router to my pc for a minecraft server(Port 25565) for about 2 days and nothing i have tried worked. I have been using www.canyouseeme.org to test.

Is the ip address you blocked out on the wan port the same as displays on the canyouseeme site as your IP. If they are different you do not have a public IP and it likely will never work.
Try to use the DMZ option instead. It is much simpler than port forwarding. If dmz works then there is something wrong with your port forwarding rules. If DMZ does not work then something else is causing the issue, make sure the server actually responds to that port
The application path worked however we keep getting a connection timed out error when trying to connectHi,
Return to "Port Forwarding" then in "protocol" select only "TCP" then in "WAN Connection" select "omci-ipt4_pppoe_1", don't put anything in "wan host start " and "wan host end" then save and see if it works.
If it still does not work go to "application list" and click on "click here to add an application", in "Protocol", select "TCP" and you put the port in all the boxes, you give the application a name and you save then you go to "Port Forwarding 'application list" and then you select "omci-ipt4_pppoe_1" in "wan connection", you put the ip adress of your concerned device, then you select the name of the application previously saved then you click on "Add" and you see the result.
My public Ip seems to change, its the result i get when i type 'whats my public ip address' into google, I read this needs to be static so how do i set that
Hi Cole,Other info:
Windows 10 PC
Asus Strix z270g
my ISP is SLT (Sri Lanka Telecom)
Im using a second router as a switch but it has no inputs as far as i can tell (i have tried without this too plugging directly into router No. 1)