I had a *powered* hard drive a while back that started having issues, but only on older files. Turns out the file system (and disk) were well over 10 years old and the drive did nothing to 'freshen up' data, so newer written data was fine and really old files had a few errors. (I ran some utility or other to read and rewrite the entire drive, then it was fine again.)
Early drives were less likely to do background maintenance, because it was less of an issue. If you had an older OS on it, you might have to manually enable Trim (unless the drive is so old that it doesn't even support it).
One thing I'd caution people against is naively charging it with a block-level operation to "freshen" an old drive. I made that mistake and almost killed a drive. What apparently happened is that some NAND cells hadn't been written since either early in the drives service or maybe since it was manufactured. Those were the blocks that failed. When the drive discovered the errors, it relocated which blocks it could recover, thus burning through its reserve of remaining capacity. Once I noticed this, I halted the operation in time to see the reserve capacity was almost gone.
Then, what I did was to manually run Trim (Linux command:
fstrim
, which is safe to use on mounted filesystems). After that, I reran
badblocks
and it had no more errors. What
fstrim
does is to tell the drive's firmware which blocks don't hold any data. Apparently, doing this also causes the drive to rewrite them (probably with zeros or something) and that's why subsequently reading them no longer caused any errors.
BTW, this whole issue affects USB sticks and SD cards, not just SATA SSDs. Some of those support Trim, so make sure to try trimming
first, before doing a (preferably) file-level or block-level operation to freshen them.
I'd 'trust' HDD over SSD to not spontaneously lose the data,
Don't. I think they're not guaranteed to retain data in cold storage for any longer than the warranty period. I think retention is affected by temperature, so basement storage is much better than attic, although if your basement is very damp then maybe double-bag the drives with a fresh silica gel packet.
if it's a modern high capacity drive the helium could leak out
Fortunately, most drives don't contain helium. I think that's mainly used to improve energy efficiency, but it's a waste of a non-renewable resource. I sort of doubt loss of helium in your drive will affect its operation, but I don't know too much about this particular topic.
The SSD is more prone to loss but the HDD has all those moving parts to have something go wrong with.
With HDDs, what I worry about is an array failure. I run RAID-6, which means I can recover from up to 2 drive losses and effectively mitigates against mechanical failures, in small arrays. However, if the entire stack becomes corrupt, then you're still hosed.